Run the SafeLogger migration manually #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
added a commit
to palantir/safe-logging
that referenced
this pull request
Jul 22, 2021
This prevents issues in projects which enforce `NullAway`. Nullable exceptions for debugging based on some predicate are relatively common. This impacts us because we often configure nullaway to enforce with the `com.palantir` prefix which covers `com.palantir.logsafe.logger` but not `org.slf4j`. Issue discovered here: palantir/dialogue#1340
carterkozak
force-pushed
the
ckozak/safelog
branch
from
8cc984b to
a056eaa
Compare
jkozlowski
approved these changes
Jul 23, 2021
carterkozak
force-pushed
the
ckozak/safelog
branch
from
a056eaa to
e81e8f1
Compare
|
Released 3.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==COMMIT_MSG==
Migrate logging from slf4j to safe-logging loggers
==COMMIT_MSG==
First commit is automated. Second commit, 69224ee, includes manual changes.