Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement experimental socks5 proxy support #1427

Merged
merged 4 commits into from
Oct 4, 2021
Merged

Implement experimental socks5 proxy support #1427

merged 4 commits into from
Oct 4, 2021

Conversation

carterkozak
Copy link
Contributor

After this PR

==COMMIT_MSG==
Implement experimental socks5 proxy support using the dialogue.experimental.socks5.proxy property
==COMMIT_MSG==

@carterkozak
Implement experimental socks5 proxy support
97df3a3 
Using the `dialogue.experimental.socks5.proxy` property
@changelog-app
Copy link

changelog-app bot commented Oct 4, 2021 •
edited by carterkozak
Loading

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Implement experimental socks5 proxy support using the dialogue.experimental.socks5.proxy property

Check the box to generate changelog(s)

  • Generate changelog entry

CRogers
CRogers approved these changes Oct 4, 2021
View reviewed changes
Copy link

@CRogers CRogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speedy!

@carterkozak
Copy link
Contributor Author

Well, I can confirm nothing calls SocketConfig.getSocksProxyAddress after I set it, so that's a bit of a problem, I'll continue debugging!

@bulldozer-bot bulldozer-bot bot merged commit af6f4c8 into develop Oct 4, 2021
@bulldozer-bot bulldozer-bot bot deleted the ckozak/experimental_socks5_proxy branch October 4, 2021 16:48
@svc-autorelease
Copy link
Collaborator

Released 3.21.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CRogers CRogers CRogers approved these changes

@xRuiAlves xRuiAlves Awaiting requested review from xRuiAlves

Assignees
No one assigned
Labels
autorelease merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carterkozak @svc-autorelease @CRogers @svc-changelog