Track host resolution failure metrics #1582
Conversation
Generate changelog in
|
There was a problem hiding this comment.
#1583 shows what is likely a better place for such logic to live
dialogue-apache-hc5-client/src/main/metrics/dialogue-apache-client-metrics.yml
Outdated
Show resolved
Hide resolved
dialogue-apache-hc5-client/src/main/java/com/palantir/dialogue/hc5/UnknownHostCounter.java
Outdated
Show resolved
Hide resolved
...-apache-hc5-client/src/test/java/com/palantir/dialogue/hc5/ApacheHttpClientChannelsTest.java
Outdated
Show resolved
Hide resolved
raiju
force-pushed
the
sk/metric-for-dns-failures
branch
from
e13221e to
5f89743
Compare
|
@carterkozak Can you take another look? Do you have an opinion on separating the host -> IP address & canonical host name resolution? For my use-case they should be similar. Happy to add it as an arg to the meter/isolate it to IP resolution if you'd prefer. |
...-apache-hc5-client/src/test/java/com/palantir/dialogue/hc5/ApacheHttpClientChannelsTest.java
Outdated
Show resolved
Hide resolved
...-apache-hc5-client/src/test/java/com/palantir/dialogue/hc5/ApacheHttpClientChannelsTest.java
Outdated
Show resolved
Hide resolved
|
lgtm, let's fix up the assertion message before merging 👍 |
In practice I think we're only resolving host -> IP, not canonical host names. Looks good as written :-) |
|
@carterkozak Should be fixed now |
|
Released 3.44.0 |
Before this PR
After this PR
==COMMIT_MSG==
Track host resolution failure metrics
==COMMIT_MSG==
Possible downsides?