Detect usage of deprecated cipher suites #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
|
Just waiting on cjr 7.29.0 to publish with palantir/conjure-java-runtime#2272 for this to compile. |
jkozlowski
reviewed
Feb 25, 2022
| tags: | ||
| - name: client-name | ||
| - name: client-type | ||
| values: [ apache-hc5 ] |
There was a problem hiding this comment.
Does this provide value now? Do we run with any other client? I guess might as well leave lest we switch to something else?
There was a problem hiding this comment.
Ya, I figured it was best to add to all these metrics and include the static value to simplify our code.
jkozlowski
approved these changes
Feb 25, 2022
|
Released 3.52.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR
==COMMIT_MSG==
Detect usage of deprecated cipher suites
==COMMIT_MSG==
Risks
Unlike servers, when a deprecated cipher is used, we don't have confidence that its removal would cause requests to fail. Servers ultimately choose which cipher to use, it's relatively common for java 8 servers to prefer less secure CBC ciphers over GCM due to the faster native implementation (GCM ciphers are much faster on modern jvms), however we can gauge the potential scale of impact prior to removing ciphers this way.