Remove redundant SSL work from client config creation #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
reviewed
Apr 25, 2023
dialogue-clients/src/main/java/com/palantir/dialogue/clients/AugmentClientConfig.java
Outdated
Show resolved
Hide resolved
…om:palantir/dialogue into jcorreia/redundantSSLInitializationRemoval
jpcorreia99
commented
Apr 25, 2023
| @@ -16,6 +16,7 @@ dependencies { | |||
| implementation 'com.google.errorprone:error_prone_annotations' | |||
| implementation 'com.google.guava:guava' | |||
| implementation 'com.palantir.conjure.java.runtime:keystores' | |||
| implementation 'com.palantir.conjure.java.api:ssl-config' | |||
There was a problem hiding this comment.
Had to add this line as CI was failing because of implicit dependencies
carterkozak
approved these changes
Apr 25, 2023
bulldozer-bot
bot
deleted the
jcorreia/redundantSSLInitializationRemoval
branch
|
Released 3.82.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Currently, we do redundant work when building the client configuration.
The call to
ClientConfigurations.ofalready initializes a fullSSLContext, however an SSLContext is initialized again here since we want to optionally use a security provider and also control cache size.This PR uses the new overloaded
ClientConfigurations.of()method that accepts aTrustContextFactory. This interface allows us to fully control how SSL related classes are provided and removes the redundant SSL/IO work that was being done in the initialof()call.After this PR
==COMMIT_MSG==
Use TrustContextFactory when building ClientConfiguration instead of overwriting already performed SSL work.
==COMMIT_MSG==