Dialogue guards against HTTPCLIENT-1924 client self-closure #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
force-pushed
the
ckozak/hc_self_closure
branch
from
86f3e7b to
7111a5f
Compare
carterkozak
commented
Jun 13, 2023
|
|
||
| @Override | ||
| public void writeTo(OutputStream _output) { | ||
| throw new StackOverflowError(); |
There was a problem hiding this comment.
This makes for a nice test, and I suspect is similar to the issue which prompted this change, but in practice I don't think httpclient should actually close the connection pool when an error is thrown from this portion of the request. I will follow up separately on that.
carterkozak
commented
Jun 13, 2023
Comment on lines
+88
to
+89
| * https://github.com/apache/httpcomponents-client/blob/5b61e132c3871ddfa967ab21b3af5d6d738bc6e8/ | ||
| * httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/MainClientExec.java#L161-L164 |
There was a problem hiding this comment.
hyperlink: MainClientExec.java#L161-L164
mpritham
approved these changes
Jun 13, 2023
|
Released 3.85.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
The underlying http client closes itself when an Error is thrown.
After this PR
==COMMIT_MSG==
Dialogue guards against HTTPCLIENT-1924 client self-closure
==COMMIT_MSG==
Possible downsides?
In cases that would previously self-close, we're guaranteed that a connection will leak. Our connection pool allows two billion entries, so it's not the worst thing in the world so long as it doesn't happen in a hot loop, which is unlikely, and in the unlikely worst case causes similar issues to the self-closure problem.