BinaryRequestBody and ContentBody use InputStream.transferTo(OutputStream) #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for optimization when underlying input stream (such as ByteArrayInputStream, ChannelInputStream) overrides transferTo(OutputStream) to avoid extra array allocations and copy larger chunks at a time (e.g. allowing 16KiB chunks via ApacheHttpClientBlockingChannel.ModulatingOutputStream from #1790). When moving to JDK 21+, this will also enable 16KiB byte chunk copies via InputStream.transferTo(OutputStream) per JDK-8299336, where as on JDK < 21 and when using Guava ByteStreams.copy 8KiB byte chunk copies are used. References: * palantir/hadoop-crypto#586 * https://bugs.openjdk.org/browse/JDK-8299336 * https://bugs.openjdk.org/browse/JDK-8067661 * https://bugs.openjdk.org/browse/JDK-8265891 * https://bugs.openjdk.org/browse/JDK-8273038 * https://bugs.openjdk.org/browse/JDK-8279283 * https://bugs.openjdk.org/browse/JDK-8296431
Generate changelog in
|
carterkozak
approved these changes
Jul 28, 2023
|
Released 3.88.0 |
schlosna
changed the title
jkozlowski
reviewed
Jul 28, 2023
| @@ -39,7 +38,7 @@ final class InputStreamContentBody implements ContentBody { | |||
|
|
|||
| @Override | |||
| public void writeTo(OutputStream output) throws IOException { | |||
| ByteStreams.copy(inputStream, output); | |||
| inputStream.transferTo(output); | |||
There was a problem hiding this comment.
Should we get this into error-prone if this is now the preferred approach? I know I'm guilty of many uses of this method
There was a problem hiding this comment.
good call, I'd like to write up an error-prone rule to migrate folks soon.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Dialogue used Guava
ByteStreams.copyfor 8KiB byte buffer chunk copies.After this PR
==COMMIT_MSG==
BinaryRequestBodyandContentBodyuseInputStream.transferTo(OutputStream)Allow for optimization when underlying input stream (such as
ByteArrayInputStream,ChannelInputStream) overridestransferTo(OutputStream)to avoid extra array allocations and copy larger chunks at a time (e.g. allowing 16KiB chunks viaApacheHttpClientBlockingChannel.ModulatingOutputStreamfrom #1790).When running on JDK 21+, this also enables 16KiB byte chunk copies via
InputStream.transferTo(OutputStream)per JDK-8299336, where as on JDK < 21 and when using GuavaByteStreams.copy8KiB byte chunk copies are used.References:
==COMMIT_MSG==
Possible downsides?