UrlBuilder supports adding multiple path segments at once #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
reviewed
Sep 14, 2023
| Meter meter = metrics.deprecations(endpoint.serviceName()); | ||
|
|
||
| // lazily create meter metric name only if deprecated endpoint is accessed | ||
| Supplier<Meter> meterSupplier = Suppliers.memoize(() -> metrics.deprecations(endpoint.serviceName())); |
There was a problem hiding this comment.
I imagine this came up with something that used sticky sessions? iirc each sticky session client re-creates endpointchannel instances, which is why we memoize some other metrics.
There was a problem hiding this comment.
yep, I saw this on some of the major clients that use sticky sessions
carterkozak
reviewed
Sep 14, 2023
| @@ -80,7 +80,7 @@ public void fill(ListMultimap<String, String> parameters, UrlBuilder url) { | |||
| if (segment.fixed != null) { | |||
| url.pathSegment(segment.fixed); | |||
| } else { | |||
| parameters.get(segment.variable).forEach(url::pathSegment); | |||
| url.pathSegments(parameters.get(segment.variable)); | |||
|
Released 3.92.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
For high volume services, adding the URL path segments can trigger reallocations as the list resizes.
Calls to non-deprecated endpoints incurred the cost of creating the deprecation metric name.
After this PR
==COMMIT_MSG==
UrlBuilder supports adding multiple path segments at once.
Deprecation metric is only created when a deprecated endpoint is invoked.
==COMMIT_MSG==
Possible downsides?