Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProtocolVersionFilteringDialogueDnsResolver logs localhost at debug #2181

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

carterkozak
Copy link
Contributor

We most often expect localhost dns resolution to produce both ipv4 and ipv6 addresses, so we can opt out of logging at info level in that case.
We will also reduce non-localhost to debug later on, however we bias toward observability during feature rollout.

==COMMIT_MSG==
ProtocolVersionFilteringDialogueDnsResolver logs localhost at debug
==COMMIT_MSG==

We most often expect localhost dns resolution to produce both
ipv4 and ipv6 addresses, so we can opt out of logging at info
level in that case.
We will also reduce non-localhost to debug later on, however we
bias toward observability during feature rollout.
@changelog-app
Copy link

changelog-app bot commented Mar 1, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

ProtocolVersionFilteringDialogueDnsResolver logs localhost at debug

Check the box to generate changelog(s)

  • Generate changelog entry

bjlaub
bjlaub previously approved these changes Mar 1, 2024
@bulldozer-bot bulldozer-bot bot merged commit 79f0c35 into develop Mar 1, 2024
6 checks passed
@bulldozer-bot bulldozer-bot bot deleted the ckozak/addr_filter_logging branch March 1, 2024 16:19
@svc-autorelease
Copy link
Collaborator

Released 3.118.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants