Enable DNS node discovery by default

changelog/@unreleased/pr-2182.v2.yml

@@ -0,0 +1,5 @@
+type: feature
+feature:
+  description: Enable DNS node discovery by default
+  links:
+  - https://github.com/palantir/dialogue/pull/2182

dialogue-clients/src/main/java/com/palantir/dialogue/clients/ReloadingClientFactory.java

@@ -127,12 +127,6 @@ public Channel getNonReloadingChannel(String channelName, ClientConfiguration in
                 params.runtime().clients());
     }
 
-    // allow enabling dns node discovery by setting an environment variable
-    // note that this can still be disabled explicitly via the factory, but having a global flag
-    // that overrides the default value allows for enabling this behavior without explicit code
-    // changes
-    private static final String ENABLE_DNS_NODE_DISCOVERY_ENV_VAR = "DIALOGUE_ENABLE_EXPERIMENTAL_DNS_NODE_DISCOVERY";
-
     @Value.Immutable
     interface ReloadingParams extends AugmentClientConfig {
 
@@ -172,7 +166,7 @@ default Duration dnsRefreshInterval() {
 
         @Value.Default
         default boolean dnsNodeDiscovery() {
-            return "true".equalsIgnoreCase(System.getenv(ENABLE_DNS_NODE_DISCOVERY_ENV_VAR));
+            return true;
         }
 
         Optional<ExecutorService> blockingExecutor();