Dialogue DNS logging provides higher signal with less noise #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
commented
Mar 8, 2024
Comment on lines
+114
to
+124
| @Unsafe | ||
| @Nullable | ||
| static String tryGetHost(@Unsafe String uriString) { | ||
| try { | ||
| URI uri = new URI(uriString); | ||
| return uri.getHost(); | ||
| } catch (URISyntaxException | RuntimeException e) { | ||
| log.debug("Failed to parse URI", e); | ||
| return null; | ||
| } | ||
| } |
There was a problem hiding this comment.
Extracted from a lambda in DialogueDnsResolutionWorker to reuse within describeHostname. There's a similar method in ReloadingClientFactory which doesn't share this implementation because it's where we provide higher priority logging and metrics for invalid URIs -- we don't want to duplicate that N times for a single failure.
carterkozak
commented
Mar 8, 2024
| @@ -186,7 +186,7 @@ public <T> T getNonReloading(Class<T> clazz, ServiceConfiguration serviceConf) { | |||
| Channel channel = new LiveReloadingChannel( | |||
| DnsSupport.pollForChanges( | |||
| params.dnsNodeDiscovery(), | |||
| DnsPollingSpec.SERVICE_CONFIG, | |||
| DnsPollingSpec.serviceConfig(channelName), | |||
There was a problem hiding this comment.
I updated these so that we'll get more specific metric tags describing ongoing work, and used the info within the background DNS polling task failure logging so we don't have to guess about the unsafe URI.
mpritham
approved these changes
Mar 8, 2024
|
Released 3.121.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==COMMIT_MSG==
Dialogue DNS logging provides higher signal with less noise
==COMMIT_MSG==