Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogue ChannelCache uses weak values to allow collection of old data #2194

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

carterkozak
Copy link
Contributor

Before this PR

The inclusion of resolved IP addresses in channels caused the cache to become full over time, when hosts are rotated naturally over time. This behavior is desirable, because we're able to account for individual nodes/routes in dialogue node selection, however the channel cache didn't have a way to forget old targets.

After this PR

==COMMIT_MSG==
Dialogue ChannelCache uses weak values to allow collection of old data
==COMMIT_MSG==

Possible downsides?

It's possible that creation of a single client in a loop will re-create the same data, and allow it to be collected, re-running the same work more than we'd like. This is unlikely, as clients are generally created and held via strong references, and hot re-creation of channels is an anti-pattern.

@changelog-app
Copy link

changelog-app bot commented Mar 11, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Dialogue ChannelCache uses weak values to allow collection of old data

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit 7f43e18 into develop Mar 11, 2024
6 checks passed
@bulldozer-bot bulldozer-bot bot deleted the ckozak/channelcache_weak_values branch March 11, 2024 14:10
@svc-autorelease
Copy link
Collaborator

Released 3.122.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants