Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cache with weak keys in ChannelToEndpointChannel #2367

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

pkoenig10
Copy link
Member

See #2366 (comment).

This also effectively reverts #1414 now that we've removed isConstant.

We probably should not merge this until palantir/conjure-java-runtime#2973 is merged.

@changelog-app
Copy link

changelog-app bot commented Sep 30, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Dialogue produces timer metrics for all endpoints.

Check the box to generate changelog(s)

  • Generate changelog entry

@pkoenig10 pkoenig10 force-pushed the pkoenig/endpointChannelCache branch from c3bbfb9 to 5a23204 Compare September 30, 2024 21:26
Copy link
Contributor

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carterkozak
Copy link
Contributor

This project depends on a version of CJR which includes palantir/conjure-java-runtime#2973, however it's possible that some projects don't declare a constraint for consistent CJR library versions across modules. The risk is minimal, since we'd only end up with cache churn that shouldn't be any worse than the existing behavior -- this should be safe to merge.

@bulldozer-bot bulldozer-bot bot merged commit f5498d1 into develop Oct 1, 2024
6 checks passed
@bulldozer-bot bulldozer-bot bot deleted the pkoenig/endpointChannelCache branch October 1, 2024 17:03
@autorelease3
Copy link

autorelease3 bot commented Oct 1, 2024

Released 4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants