-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cache with weak keys in ChannelToEndpointChannel #2367
Conversation
Generate changelog in
|
dialogue-core/src/main/java/com/palantir/dialogue/core/ChannelToEndpointChannel.java
Outdated
Show resolved
Hide resolved
dialogue-core/src/main/java/com/palantir/dialogue/core/ChannelToEndpointChannel.java
Outdated
Show resolved
Hide resolved
c3bbfb9
to
5a23204
Compare
dialogue-core/src/main/java/com/palantir/dialogue/core/ChannelToEndpointChannel.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This project depends on a version of CJR which includes palantir/conjure-java-runtime#2973, however it's possible that some projects don't declare a constraint for consistent CJR library versions across modules. The risk is minimal, since we'd only end up with cache churn that shouldn't be any worse than the existing behavior -- this should be safe to merge. |
Released 4.1.0 |
See #2366 (comment).
This also effectively reverts #1414 now that we've removed
isConstant
.We probably should not merge this until palantir/conjure-java-runtime#2973 is merged.