Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle new QoS Metadata #2375

Merged
merged 9 commits into from
Oct 21, 2024
Merged

Handle new QoS Metadata #2375

merged 9 commits into from
Oct 21, 2024

Conversation

carterkozak
Copy link
Contributor

See palantir/conjure-java-runtime-api#1231 for more information

After this PR

==COMMIT_MSG==
Handle new QoS Metadata
==COMMIT_MSG==

@changelog-app
Copy link

changelog-app bot commented Oct 8, 2024 •
edited by carterkozak
Loading

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Handle new QoS Metadata

Check the box to generate changelog(s)

  • Generate changelog entry

@carterkozak carterkozak marked this pull request as ready for review October 21, 2024 17:13
bjlaub
bjlaub reviewed Oct 21, 2024
View reviewed changes
...core/src/main/java/com/palantir/dialogue/core/PinUntilErrorNodeSelectionStrategyChannel.java
@@ -147,7 +147,9 @@ public void onSuccess(Response response) {
// workflows where it is important for a large number of requests to all land on the same node,
// even if a couple of them get rate limited in the middle.
if (Responses.isServerErrorRange(response)
|| (Responses.isQosStatus(response) && !Responses.isTooManyRequests(response))) {
|| (Responses.isQosStatus(response)
&& !Responses.isQosDueToCustom(response)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if i understand this correctly, a Due-To=CUSTOM will not count as an error for node pinning, and we will stay on the same node? What's the rationale behind that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due-to custom means the client shouldn’t attempt to interpret meaning from the failure, so we don’t route to another node in that case. Changing pinned nodes can have dramatic impacts on perf, some clients use it for cache locality, which we don’t want to give up unless we really need to (instability/etc)

bjlaub
bjlaub reviewed Oct 21, 2024
View reviewed changes
dialogue-core/src/main/java/com/palantir/dialogue/core/DialogueQosReasonDecoder.java
import com.palantir.dialogue.Response;
import java.util.Optional;

enum DialogueQosReasonDecoder implements QosResponseDecodingAdapter<Response> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason this could not live along side Response in dialogue-target and be shared across projects?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s an implementation detail, not part of the codegen target api. I don’t mind duplication for such a simple utility, primary goal is to avoid expanding the public api unnecessarily

@bjlaub
Copy link
Contributor

bjlaub commented Oct 21, 2024

👍 lgtm

@bulldozer-bot bulldozer-bot bot merged commit 882755a into develop Oct 21, 2024
6 checks passed
@bulldozer-bot bulldozer-bot bot deleted the ckozak/qos-metadata branch October 21, 2024 19:45
@autorelease3
Copy link

autorelease3 bot commented Oct 21, 2024

Released 4.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjlaub bjlaub bjlaub left review comments

@mpritham mpritham Awaiting requested review from mpritham

Assignees
No one assigned
Labels
autorelease merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carterkozak @bjlaub @svc-changelog