Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain endpoint concurrency limits on node refresh #2418

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

carterkozak
Copy link
Contributor

@carterkozak carterkozak commented Nov 13, 2024

==COMMIT_MSG==
Retain endpoint concurrency limits on refresh
==COMMIT_MSG==

@carterkozak carterkozak force-pushed the ckozak/blaub/retain-state branch from 47bda92 to 7b675b2 Compare November 13, 2024 15:21
cf.channelName(),
uriIndexForInstrumentation,
endpoint,
endpointChannelState.get(endpoint));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will fail in an edge case where the endpoint limiter is completely full from a previous refresh, so the queued channel created on the next line cannot sense the boundary condition to begin allowing requests through

@bjlaub bjlaub force-pushed the blaub/retain-state branch from 3d820e4 to 7cb1e69 Compare November 18, 2024 17:24
@carterkozak carterkozak force-pushed the ckozak/blaub/retain-state branch from 7b675b2 to f222bb9 Compare November 18, 2024 17:51
@carterkozak carterkozak changed the title [stacked] Proof of concept retaining endpoint concurrency limits on refresh Retain endpoint concurrency limits on node refresh Nov 18, 2024
@carterkozak carterkozak changed the base branch from blaub/retain-state to develop November 18, 2024 17:51
@changelog-app
Copy link

changelog-app bot commented Nov 18, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Retain endpoint concurrency limits on node refresh

Check the box to generate changelog(s)

  • Generate changelog entry

@carterkozak carterkozak marked this pull request as ready for review November 18, 2024 18:07
@carterkozak carterkozak requested a review from bjlaub November 18, 2024 18:07
@bjlaub
Copy link
Contributor

bjlaub commented Nov 18, 2024

Proof of concept retaining endpoint concurrency limits on refresh

nit: doesn't seem like a proof of concept

@bjlaub
Copy link
Contributor

bjlaub commented Nov 18, 2024

👍

@bulldozer-bot bulldozer-bot bot merged commit b8dc39c into develop Nov 18, 2024
6 checks passed
@bulldozer-bot bulldozer-bot bot deleted the ckozak/blaub/retain-state branch November 18, 2024 18:26
@autorelease3
Copy link

autorelease3 bot commented Nov 18, 2024

Released 4.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants