-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retain endpoint concurrency limits on node refresh #2418
Conversation
47bda92
to
7b675b2
Compare
cf.channelName(), | ||
uriIndexForInstrumentation, | ||
endpoint, | ||
endpointChannelState.get(endpoint)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will fail in an edge case where the endpoint limiter is completely full from a previous refresh, so the queued channel created on the next line cannot sense the boundary condition to begin allowing requests through
3d820e4
to
7cb1e69
Compare
7b675b2
to
f222bb9
Compare
Generate changelog in
|
nit: doesn't seem like a proof of concept |
👍 |
Released 4.4.0 |
==COMMIT_MSG==
Retain endpoint concurrency limits on refresh
==COMMIT_MSG==