-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[do-not-merge] Deserialize endpoint errors #2443
Draft
mpritham
wants to merge
1
commit into
develop
Choose a base branch
from
pm/endpoint-error-serde
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
mpritham
commented
Dec 5, 2024
@Safe String errorCode, | ||
@Safe String errorName, | ||
@Safe String errorInstanceId, | ||
@Safe String arg, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- can put the args into a separate record which includes matches the
parameters
map for deserialization so we don't need a custom deserializer. - let's annotate each of the parameter fields with a
@JsonProperty
mpritham
commented
Dec 5, 2024
...c/test/java/com/palantir/conjure/java/dialogue/serde/EndpointErrorsConjureBodySerDeTest.java
Outdated
Show resolved
Hide resolved
mpritham
commented
Dec 5, 2024
dialogue-serde/src/main/java/com/palantir/conjure/java/dialogue/serde/ConjureBodySerDe.java
Show resolved
Hide resolved
mpritham
force-pushed
the
pm/endpoint-error-serde
branch
4 times, most recently
from
December 6, 2024 18:28
2977345
to
6081541
Compare
mpritham
force-pushed
the
pm/endpoint-error-serde
branch
from
December 6, 2024 18:29
6081541
to
74008d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
This is a prototype PR and should not be merged.
We'd like to support the a new method in
BodySerDe
that allows the creation of deserializers given an expected result type, and a set of expected error types.A ConjureError is serialized and sent by servers. Dialogue deserializes the errors to a
SerializableError
which loses the type information of the parameters. By providing the type information of the parameters, Dialogue can deserialize the receivedConjureError
into the well-typed objects (instead of Strings).After this PR
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?