Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported mesh- URIs #2474

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Conversation

carterkozak
Copy link
Contributor

@carterkozak carterkozak commented Jan 22, 2025

We deprecated support for mesh mode about a year ago, and have removed support from our core infrastructure. The code is no longer used, and can be removed for simplicity.

This should have no impact for users.

==COMMIT_MSG==
Remove unsupported mesh- URI support. This should have no impact for users.
==COMMIT_MSG==

Possible downsides?

Possible the prefix could be hard-coded somewhere we don't expect, however if so, it's certainly not being used in a supported or intended way! We have not produced such URIs since early last year, and the infrastructure that handled such requests is gone.

We deprecated support for mesh mode several months ago, and have
removed support from our core infrastructure. The code is no
longer used, and can be removed for simplicity
@changelog-app
Copy link

changelog-app bot commented Jan 22, 2025

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Remove unsupported mesh- URI support. This should have no impact for users.

Check the box to generate changelog(s)

  • Generate changelog entry

Sorry, something went wrong.

svc-changelog and others added 2 commits January 22, 2025 18:02
Copy link
Contributor

@mpritham mpritham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bulldozer-bot bulldozer-bot bot merged commit 6c0c286 into develop Jan 23, 2025
6 checks passed
@bulldozer-bot bulldozer-bot bot deleted the ckozak/remove_mesh_mode branch January 23, 2025 15:34
@autorelease3
Copy link

autorelease3 bot commented Jan 23, 2025

⚠️ Release Failed

Label releases are not allowed to increment the major version number

If you know how to resolve this error, you can initiate a manual release using the autorelease UI.
Otherwise, please reach out to #help-devtools for assistance and include cu9631kr0bormg8s06qg as your error id.

@mpritham
Copy link
Contributor

I notice it's also in conjure-go-runtime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants