Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unused classes from dialogue-target #345

Merged
merged 2 commits into from
Feb 17, 2020
Merged

Delete unused classes from dialogue-target #345

merged 2 commits into from
Feb 17, 2020

Conversation

carterkozak
Copy link
Contributor

==COMMIT_MSG==
Delete unused classes from dialogue-target
==COMMIT_MSG==

Possible downsides?

could be used somewhere?

@changelog-app
Copy link

changelog-app bot commented Feb 17, 2020 •
edited by carterkozak
Loading

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Delete unused classes from dialogue-target

Check the box to generate changelog(s)

  • Generate changelog entry

@carterkozak
Copy link
Contributor Author

Not calling this a break because nothing touches these classes. Any use would be unrelated to dialogue.

@bulldozer-bot bulldozer-bot bot merged commit 5dfb4c0 into develop Feb 17, 2020
@bulldozer-bot bulldozer-bot bot deleted the ckozak/unused_target_classes branch February 17, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdanfox iamdanfox iamdanfox approved these changes

@ferozco ferozco Awaiting requested review from ferozco

Assignees
No one assigned
Labels
merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carterkozak @iamdanfox