Utility to safely build URLs #346
Conversation
Generate changelog in
|
| import com.palantir.dialogue.UrlBuilder; | ||
| import java.net.URL; | ||
|
|
||
| /** Convenience utility around {@link UrlBuilder}. */ |
There was a problem hiding this comment.
Why not add the render method to UrlBuilder?
There was a problem hiding this comment.
I’m worried about introducing bugs that mutate the urlBuilder state
There was a problem hiding this comment.
Method on the builder is probably fine but it adds logic to the generator target rather than the runtime, and we still risk mutation
There was a problem hiding this comment.
Sure...it just seems strange to fully encapsulate one utility class inside another. After this change UrlBuilder wouldn't need to be public, right?
There was a problem hiding this comment.
The generated Endpoint objects have a method that consumes a UrlBuilder. I think that object should become an interface to further reduce logic in the generator target API, but that can occur separately.
Deduplicate client code, and isolate unsafety around UrlBuilder mutability.
carterkozak
force-pushed
the
ckozak/base_url
branch
from
578d2c6 to
dcdd376
Compare
|
👍 policy bot? |
|
🤖 |
|
👍 |
Deduplicate client code, and isolate unsafety around UrlBuilder
mutability.
After this PR
==COMMIT_MSG==
Utility to safely build URLs
==COMMIT_MSG==