Implement an OkHttpChannels factory class #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
iamdanfox
reviewed
Feb 17, 2020
dialogue-okhttp-client/src/main/java/com/palantir/dialogue/OkHttpChannels.java
Outdated
Show resolved
Hide resolved
iamdanfox
reviewed
Feb 17, 2020
dialogue-okhttp-client/src/main/java/com/palantir/dialogue/OkHttpChannels.java
Show resolved
Hide resolved
iamdanfox
reviewed
Feb 17, 2020
| .dispatcher(dispatcher) | ||
| .connectionPool(connectionPool) | ||
| .followRedirects(false) // We implement our own redirect logic. | ||
| .sslSocketFactory(config.sslSocketFactory(), config.trustManager()) |
There was a problem hiding this comment.
have we lost the KeepAliveSslSocketFactory here? Maybe we should just make it public in c-j-r?
There was a problem hiding this comment.
That's correct, this doesn't record client tls handshake metrics or set keepalive. Agree that we should be consistent across all clients.
iamdanfox
reviewed
Feb 17, 2020
dialogue-okhttp-client/src/main/java/com/palantir/dialogue/OkHttpChannels.java
Show resolved
Hide resolved
carterkozak
force-pushed
the
ckozak/okhttp_channels_factory
branch
from
442f023 to
b718b48
Compare
iamdanfox
approved these changes
Feb 18, 2020
|
I've enabled keep-alive on the apache hc implementation in #335 :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Difficult to make an okhttp based channel.
After this PR
==COMMIT_MSG==
Implement an OkHttpChannels factory class based on CJR without duplicated functionality.
==COMMIT_MSG==
Possible downsides?
We don't really want to use okhttp, but it's helpful to have a class to compare with.