fix #301: QueuedChannel futures don't wait forever when delegates throw #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferozco
reviewed
Feb 20, 2020
| verify(delegate, times(2)).maybeExecute(endpoint, queuedRequest); | ||
| assertThat(queuedFuture).isNotDone(); | ||
|
|
||
| futureResponse.set(mockResponse); |
There was a problem hiding this comment.
I would find it helpful to leave little comments explaining what you expect to be happening since just reading the test case requires tracing through the queuedChannel impl to understand why this is testing what it says it is
There was a problem hiding this comment.
good call, updated.
Generate changelog in
|
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
futures could never be completed.
After this PR
==COMMIT_MSG==
QueuedChannel futures don't wait forever when delegates throw
==COMMIT_MSG==