All metrics include dialogueVersion #436
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
As we roll out dialogue, we could get into the situation where people show us graphs on datadog and ask "why did dialogue do that" - the first step will probably be to figure out what version of dialogue was actually in use at the time to figure out if they're experiencing a bug in latest or if they're on an old version.
After this PR
==COMMIT_MSG==
All tagged metrics produced by dialogue will now have an extra
dialogueVersion
tag.==COMMIT_MSG==
Might want to move this into tritium/metric-schema if we decide we like the pattern.
Possible downsides?