Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All metrics include dialogueVersion #436

Merged
merged 2 commits into from
Feb 26, 2020
Merged

Conversation

iamdanfox
Copy link
Contributor

Before this PR

As we roll out dialogue, we could get into the situation where people show us graphs on datadog and ask "why did dialogue do that" - the first step will probably be to figure out what version of dialogue was actually in use at the time to figure out if they're experiencing a bug in latest or if they're on an old version.

After this PR

==COMMIT_MSG==
All tagged metrics produced by dialogue will now have an extra dialogueVersion tag.
==COMMIT_MSG==

Might want to move this into tritium/metric-schema if we decide we like the pattern.

Possible downsides?

  • literally can't think of a downside here. This should not increase the cardinality at all, because I'm not expecting there to be multiple versions of dialogue inside a single service!

@changelog-app
Copy link

changelog-app bot commented Feb 26, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

All tagged metrics produced by dialogue will now have an extra dialogueVersion tag.

Check the box to generate changelog(s)

  • Generate changelog entry

@iamdanfox iamdanfox force-pushed the dfox/metric-version branch 2 times, most recently from 6892108 to dfe8e93 Compare February 26, 2020 17:33
@ferozco
Copy link
Contributor

ferozco commented Feb 26, 2020

👍

@bulldozer-bot bulldozer-bot bot merged commit 4742b92 into develop Feb 26, 2020
@bulldozer-bot bulldozer-bot bot deleted the dfox/metric-version branch February 26, 2020 17:40
@svc-autorelease
Copy link
Collaborator

Released 0.10.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants