Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the arbitrary FixedLimitedChannel #484

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Remove the arbitrary FixedLimitedChannel #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fccb7d
Remove the arbitrary FixedLimitedChannel
carterkozak Mar 4, 2020
0a17d70
Add generated changelog entries
carterkozak Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/@unreleased/pr-484.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: improvement
improvement:
description: Remove the arbitrary FixedLimitedChannel
links:
- https://github.com/palantir/dialogue/pull/484
3 changes: 0 additions & 3 deletions dialogue-core/src/main/java/com/palantir/dialogue/core/Channels.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@

public final class Channels {

private static final int MAX_REQUESTS_PER_CHANNEL = 256;

private Channels() {}

public static Channel create(Collection<? extends Channel> channels, ClientConfiguration config) {
Expand Down Expand Up @@ -104,7 +102,6 @@ public Channel build() {
.map(channel -> new TracedChannel(channel, "Dialogue-http-request"))
.map(ChannelToLimitedChannelAdapter::new)
.map(channel -> concurrencyLimiter(conf, channel, clientMetrics, clock))
.map(channel -> new FixedLimitedChannel(channel, MAX_REQUESTS_PER_CHANNEL, clientMetrics))
.collect(ImmutableList.toImmutableList());

LimitedChannel nodeSelectionStrategy = nodeSelectionStrategy(conf, limitedChannels, taggedMetrics, random);
Expand Down
97 changes: 0 additions & 97 deletions dialogue-core/src/main/java/com/palantir/dialogue/core/FixedLimitedChannel.java
View file
Open in desktop

This file was deleted.

68 changes: 0 additions & 68 deletions dialogue-core/src/test/java/com/palantir/dialogue/core/FixedLimitedChannelTest.java
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions simulation/src/test/resources/one_big_spike[UNLIMITED_ROUND_ROBIN].png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion simulation/src/test/resources/report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
one_big_spike[CONCURRENCY_LIMITER_BLACKLIST_ROUND_ROBIN].txt: success=79.0% client_mean=PT1.478050977S server_cpu=PT1M59.71393673S client_received=1000/1000 server_resps=790 codes={200=790, Failed to make a request=210}
one_big_spike[CONCURRENCY_LIMITER_PIN_UNTIL_ERROR].txt: success=81.6% client_mean=PT1.512223628S server_cpu=PT2M2.4S client_received=1000/1000 server_resps=816 codes={200=816, Failed to make a request=184}
one_big_spike[CONCURRENCY_LIMITER_ROUND_ROBIN].txt: success=81.6% client_mean=PT1.51102737S server_cpu=PT2M2.4S client_received=1000/1000 server_resps=816 codes={200=816, Failed to make a request=184}
one_big_spike[UNLIMITED_ROUND_ROBIN].txt: success=99.4% client_mean=PT1.219659027S server_cpu=PT6M55.5S client_received=1000/1000 server_resps=2770 codes={200=994, 429=6}
one_big_spike[UNLIMITED_ROUND_ROBIN].txt: success=99.8% client_mean=PT1.239331619S server_cpu=PT8M33.3S client_received=1000/1000 server_resps=3422 codes={200=998, 429=2}
one_endpoint_dies_on_each_server[CONCURRENCY_LIMITER_PIN_UNTIL_ERROR].txt: success=63.8% client_mean=PT0.6S server_cpu=PT25M client_received=2500/2500 server_resps=2500 codes={200=1594, 500=906}
one_endpoint_dies_on_each_server[CONCURRENCY_LIMITER_ROUND_ROBIN].txt: success=65.5% client_mean=PT0.6S server_cpu=PT25M client_received=2500/2500 server_resps=2500 codes={200=1638, 500=862}
one_endpoint_dies_on_each_server[UNLIMITED_ROUND_ROBIN].txt: success=65.5% client_mean=PT0.6S server_cpu=PT25M client_received=2500/2500 server_resps=2500 codes={200=1638, 500=862}
Expand Down
2 changes: 1 addition & 1 deletion simulation/src/test/resources/txt/one_big_spike[UNLIMITED_ROUND_ROBIN].txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
success=99.4% client_mean=PT1.219659027S server_cpu=PT6M55.5S client_received=1000/1000 server_resps=2770 codes={200=994, 429=6}
success=99.8% client_mean=PT1.239331619S server_cpu=PT8M33.3S client_received=1000/1000 server_resps=3422 codes={200=998, 429=2}