Report metrics for in-flight requests #486
Conversation
Generate changelog in
|
|
Draft, still needs test coverage. A couple open questions before I clean it up, will add them inline. |
| requests.active: | ||
| type: counter | ||
| tags: [stage] | ||
| docs: Number of requests that are actively running. The stage may refer to 'in-flight' requests actively executing over the wire, or 'processing' which may be awaiting a client or backing off for a retry. |
There was a problem hiding this comment.
Looking for feedback on naming dialogue.client.requests.active should probably use singular request.
stage in-flight: maybe rename to wire.
processing is fairly vague, but as such it's not going to be incorrect.
There was a problem hiding this comment.
request.active seems alright. Agree in-flight is a bit confusing since from a users perspective the request is in-flight as soon as it hits our code. Perhaps running and queued for consistency with CJR?
There was a problem hiding this comment.
I like it, thanks!
There was a problem hiding this comment.
oh hmm, queued isn't quite right because it includes everything, both queued and running.
|
👍 |
|
Released 0.14.1 |
Before this PR
Difficult to tell how many requests were actively in flight.
After this PR
==COMMIT_MSG==
Report metrics for in-flight requests
==COMMIT_MSG==
Possible downsides?
metrics ain't free?