Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency Limits decrease in response to 429, 503 and 500s #513

Merged
merged 3 commits into from
Mar 9, 2020

Conversation

ferozco
Copy link
Contributor

@ferozco ferozco commented Mar 9, 2020

Before this PR

We would only reduce the number of limits if the server returned an explicit 429.

After this PR

==COMMIT_MSG==
Reduce the number of available concurrency limits in response to 429's and 500's
==COMMIT_MSG==

I could go either way on whether general 500's should result in reduced concurrency limits.

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Mar 9, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Reduce the number of available concurrency limits in response to 429's and 5xx's

Check the box to generate changelog(s)

  • Generate changelog entry

@ferozco ferozco requested a review from carterkozak March 9, 2020 14:40
@carterkozak
Copy link
Contributor

- Reduce the number of available concurrency limits in response to 429's and 500's
+ Reduce the number of available concurrency limits in response to 429's and 5xx's

Copy link
Contributor

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bulldozer-bot bulldozer-bot bot merged commit 6281c6c into develop Mar 9, 2020
@bulldozer-bot bulldozer-bot bot deleted the fo/concurrency-limit branch March 9, 2020 14:48
@svc-autorelease
Copy link
Collaborator

Released 0.19.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants