Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument client TLS handshakes #542

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Instrument client TLS handshakes #542

merged 2 commits into from
Mar 19, 2020

Conversation

carterkozak
Copy link
Contributor

==COMMIT_MSG==
Instrument client TLS handshakes
==COMMIT_MSG==

@carterkozak carterkozak requested a review from iamdanfox March 19, 2020 13:30
@changelog-app
Copy link

changelog-app bot commented Mar 19, 2020 •
edited by carterkozak
Loading

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Instrument client TLS handshakes

Check the box to generate changelog(s)

  • Generate changelog entry

@carterkozak
Copy link
Contributor Author

@ferozco I can't seem to add you as a reviewer on this, not sure what's going on!

@iamdanfox
Copy link
Contributor

iamdanfox commented Mar 19, 2020 •
edited
Loading

I think all the graphs we have at the moment assume that these connections are only instrumented on the server-side - can we differentiate the client & server side in the metric names somehow?

Also if these just say tls.handshake then in our birds-eye graphs we might end up double-counting requests that come from dialogue clients?

@carterkozak
Copy link
Contributor Author

The server produces metrics tagged context: server, CJR already provides these from the client side:
palantir/conjure-java-runtime#1446

iamdanfox
iamdanfox approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@iamdanfox iamdanfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah great, ok I see we'd get a context: gatekeeperservice tag in DD.

@bulldozer-bot bulldozer-bot bot merged commit b4feccc into develop Mar 19, 2020
@bulldozer-bot bulldozer-bot bot deleted the ckozak/instrument_tls_handshakes branch March 19, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdanfox iamdanfox iamdanfox approved these changes

Assignees
No one assigned
Labels
merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carterkozak @iamdanfox