Implement support for HEAD requests #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
commented
Apr 6, 2020
| GET, | ||
| HEAD, | ||
| PATCH, | ||
| POST, | ||
| PUT, |
iamdanfox
reviewed
Apr 6, 2020
...ache-hc4-client/src/main/java/com/palantir/dialogue/hc4/ApacheHttpClientBlockingChannel.java
Show resolved
Hide resolved
|
Lets add the response type validation, then looks good 👍 |
iamdanfox
reviewed
Apr 6, 2020
| } catch (IOException e) { | ||
| throw new SafeRuntimeException("Failed to get response stream", e); | ||
| HttpEntity entity = response.getEntity(); | ||
| if (entity != null) { |
There was a problem hiding this comment.
nice cheeky little bugfix!
There was a problem hiding this comment.
test found a NPE bug :-]
iamdanfox
approved these changes
Apr 6, 2020
|
Released 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==COMMIT_MSG==
Implement support for HEAD requests. This allows dialogue channels to replace existing jaxrs client infrastructure.
==COMMIT_MSG==