Fix deserialization of structured errors after retries are exhausted

[iamdanfox]

Before this PR

All versions of dialogue contain this bug: when we exhaust retries and pass the final response to the ErrorDecoder, the response body has already been closed so it can't read the json. This means every structured error comes out as an UnknownRemoteException:

com.palantir.conjure.java.api.errors.UnknownRemoteException: Error 429. (Failed to parse response body as SerializableError.)
	at com.palantir.conjure.java.dialogue.serde.DefaultClients.newUnknownRemoteException(DefaultClients.java:120)
	at com.palantir.conjure.java.dialogue.serde.DefaultClients.block(DefaultClients.java:94)
	at com.palantir.dialogue.example.SampleServiceBlocking$1.voidToVoid(SampleServiceBlocking.java:35)
	...
Caused by: com.palantir.conjure.java.api.errors.UnknownRemoteException: Error 429. (Failed to parse response body as SerializableError.)
	at com.palantir.conjure.java.dialogue.serde.ErrorDecoder.decode(ErrorDecoder.java:57)
	at com.palantir.conjure.java.dialogue.serde.ConjureBodySerDe$EmptyBodyDeserializer.deserialize(ConjureBodySerDe.java:333)
	at com.palantir.conjure.java.dialogue.serde.ConjureBodySerDe$EmptyBodyDeserializer.deserialize(ConjureBodySerDe.java:320)
	at com.google.common.util.concurrent.AbstractTransformFuture$TransformFuture.doTransform(AbstractTransformFuture.java:242)
	...
Caused by: org.apache.http.ConnectionClosedException: Premature end of Content-Length delimited message body (expected: 164; received: 0)
	at org.apache.http.impl.io.ContentLengthInputStream.read(ContentLengthInputStream.java:178)
	at org.apache.http.conn.EofSensorInputStream.read(EofSensorInputStream.java:135)
	at java.base/sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:284)
	at java.base/sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:326)
	at java.base/sun.nio.cs.StreamDecoder.read(StreamDecoder.java:178)
	at java.base/java.io.InputStreamReader.read(InputStreamReader.java:185)
	at java.base/java.io.Reader.read(Reader.java:229)
	at com.google.common.io.CharStreams.copyReaderToBuilder(CharStreams.java:119)
	at com.google.common.io.CharStreams.toStringBuilder(CharStreams.java:177)
	at com.google.common.io.CharStreams.toString(CharStreams.java:163)
	at com.palantir.conjure.java.dialogue.serde.ErrorDecoder.toString(ErrorDecoder.java:77)
	at com.palantir.conjure.java.dialogue.serde.ErrorDecoder.decode(ErrorDecoder.java:55)

This is obviously different from c-j-r's behaviour, and means anyone's catch(RemoteException) blocks won't get triggered.

After this PR

==COMMIT_MSG==
Structured errors are now correctly deserialized when requests exhaust all available retries. (Previously they would always appear as an UnknownRemoteException.)
==COMMIT_MSG==

Possible downsides?

[changelog-app]

Generate changelog in changelog/@unreleased

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Structured errors are now correctly deserialized when requests exhaust all available retries. (Previously they would always appear as an UnknownRemoteException.)

Check the box to generate changelog(s)

• Generate changelog entry

[carterkozak]

Great find!

[iamdanfox]

👨‍🎨

[svc-autorelease]

Released 1.11.2

[carterkozak]

For what it's worth I think this was only a bug for 503 and 429 responses where our infrastructure sends empty response bodies.