Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrying executor ThreadFacotory instrumentation #652

Merged
merged 2 commits into from
Apr 15, 2020
Merged

Retrying executor ThreadFacotory instrumentation #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76e9ae0
Retrying executor ThreadFacotory instrumentation
carterkozak Apr 15, 2020
c2346ea
Add generated changelog entries
carterkozak Apr 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/@unreleased/pr-652.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: improvement
improvement:
description: Retrying executor ThreadFacotory instrumentation
links:
- https://github.com/palantir/dialogue/pull/652
13 changes: 9 additions & 4 deletions dialogue-core/src/main/java/com/palantir/dialogue/core/RetryingChannel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
import com.palantir.tracing.Tracers;
import com.palantir.tritium.metrics.MetricRegistries;
import com.palantir.tritium.metrics.registry.DefaultTaggedMetricRegistry;
import com.palantir.tritium.metrics.registry.SharedTaggedMetricRegistries;
import com.palantir.tritium.metrics.registry.TaggedMetricRegistry;
import java.io.IOException;
import java.net.SocketTimeoutException;
Expand Down Expand Up @@ -67,11 +68,15 @@ final class RetryingChannel implements Channel {
* edge case where services are already operating in a degraded state and we should not
* spam servers.
*/
@SuppressWarnings("deprecation") // Singleton registry for a singleton executor
static final Supplier<ScheduledExecutorService> sharedScheduler =
Suppliers.memoize(() -> Executors.newSingleThreadScheduledExecutor(new ThreadFactoryBuilder()
.setNameFormat(SCHEDULER_NAME + "-%d")
.setDaemon(false)
.build()));
Suppliers.memoize(() -> Executors.newSingleThreadScheduledExecutor(MetricRegistries.instrument(
SharedTaggedMetricRegistries.getSingleton(),
Copy link
Contributor

@ferozco ferozco Apr 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this correctly wired up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WC

new ThreadFactoryBuilder()
.setNameFormat(SCHEDULER_NAME + "-%d")
.setDaemon(false)
.build(),
SCHEDULER_NAME)));

@SuppressWarnings("UnnecessaryLambda") // no allocations
private static final BiFunction<Endpoint, Response, Throwable> qosThrowable = (endpoint, response) ->
Expand Down