Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare PathTemplate is Immutable #667

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Conversation

iamdanfox
Copy link
Contributor

@iamdanfox iamdanfox commented Apr 23, 2020

When hand-rolling a dialogue client, I got these annoying warnings:

> Task :multipass-oauth2-client:compileJava
/Volumes/git/multipass-grant-types/multipass-oauth2-client/src/main/java/com/palantir/multipass/client/api/MultipassOAuth2Endpoints.java:16: warning: [ImmutableEnumChecker] enums should be immutable: 'token' has field 'pathTemplate' of type 'com.palantir.dialogue.PathTemplate', the declaration of type 'com.palantir.dialogue.PathTemplate' is not annotated with @com.google.errorprone.annotations.Immutable
        private final PathTemplate pathTemplate =
                                   ^
    (see https://errorprone.info/bugpattern/ImmutableEnumChecker)
/Volumes/git/multipass-grant-types/multipass-oauth2-client/src/main/java/com/palantir/multipass/client/api/MultipassOAuth2Endpoints.java:46: warning: [ImmutableEnumChecker] enums should be immutable: 'revokeToken' has field 'pathTemplate' of type 'com.palantir.dialogue.PathTemplate', the declaration of type 'com.palantir.dialogue.PathTemplate' is not annotated with @com.google.errorprone.annotations.Immutable
        private final PathTemplate pathTemplate =
                                   ^
    (see https://errorprone.info/bugpattern/ImmutableEnumChecker)
2 warnings

@policy-bot policy-bot bot requested a review from dansanduleac April 23, 2020 16:55
@iamdanfox iamdanfox requested review from carterkozak and ferozco and removed request for dansanduleac April 23, 2020 16:55
@bulldozer-bot bulldozer-bot bot merged commit 11bdc47 into develop Apr 23, 2020
@bulldozer-bot bulldozer-bot bot deleted the dfox-patch-22091 branch April 23, 2020 18:15
@svc-autorelease
Copy link
Collaborator

Released 1.27.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants