Blocking clients wrap checked failures with DialogueException #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
Throwing an UncheckedExecutionException from `fooService.ping()` isn't terribly helpful and doesn't make the type of issue immediately obvious.
carterkozak
force-pushed
the
ckozak/wrap_failures_unknownremote
branch
from
639e0dc to
714c77e
Compare
carterkozak
changed the title
iamdanfox
approved these changes
May 19, 2020
|
Released 1.46.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throwing an UncheckedExecutionException from
fooService.ping()isn't terribly helpful and doesn't make the type of issue
immediately obvious.
After this PR
==COMMIT_MSG==
Blocking clients wrap checked failures with UnknownRemoteException
==COMMIT_MSG==