Excavator: Upgrades Baseline to the latest version #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svc-excavator-bot
force-pushed
the
roomba/latest-baseline-oss
branch
5 times, most recently
from
7280bec to
cbb7fdd
Compare
svc-excavator-bot
force-pushed
the
roomba/latest-baseline-oss
branch
10 times, most recently
from
1a54513 to
a1a650e
Compare
svc-excavator-bot
force-pushed
the
roomba/latest-baseline-oss
branch
6 times, most recently
from
9f431af to
2cb2979
Compare
svc-excavator-bot
force-pushed
the
roomba/latest-baseline-oss
branch
from
2cb2979 to
92d3afd
Compare
felixdesouza
approved these changes
Sep 20, 2019
| @@ -196,7 +196,7 @@ private static Object wrapNameService(String className, Object delegate, Object | |||
| } | |||
|
|
|||
| @Override | |||
| public Object invoke(Object proxy, Method method, Object[] args) throws Throwable { | |||
| public Object invoke(Object _proxy, Method method, Object[] args) throws Throwable { | |||
There was a problem hiding this comment.
Does checkstyle accept this being proxy?
| @@ -45,7 +44,9 @@ public DockerProxySelector(Cluster containers, DockerContainerInfo containerInfo | |||
|
|
|||
| @Override | |||
| public void connectFailed(URI uri, SocketAddress sa, IOException ioe) { | |||
| Preconditions.checkArgument(uri != null && sa != null && ioe != null, "Invalid connectFailed call"); | |||
| com.palantir.logsafe.Preconditions.checkArgument( | |||
There was a problem hiding this comment.
Can you convert this to an import instead of splitting it over multiple lines?
There was a problem hiding this comment.
eurgh, yeah, I thought it was doing the thing where it did a fq import if there were invocations of both Preconditions but sure okay.
SerialVelocity
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
excavator is a bot for automating changes across repositories.
Changes produced by the roomba/latest-baseline-oss check.
Release Notes
0.51.0
./gradlew ideadeletes redundant ipr files (Excavator: Upgrade buildscript dependencies #550)0.51.1
0.52.0
com.palantir.baseline-exact-dependencieshelps declare necessary and sufficient dependencies (Excavator: Format Java files #548)0.53.0
0.54.0
com.palantir.baseline-release-compatibilityplugin (Excavator: Upgrade buildscript dependencies #582)0.55.0
[break] Enable running of unique class check on multiple configurations (#583)
0.55.1
[fix] checkImplicitDependencies shouldn't count ignored artifacts (#601)
0.55.2
[fix] BaselineReleaseCompatibility up-to-date checking of compile tasks (#605)
0.56.0
[feature] Add an errorprone rule GradleCacheableTaskAction that prevents passing a lambda to Task.doFirst or Task.doLast when implementing gradle plugins (#608)
0.57.0
Iterables.partition(List, int)withLists.partition(List, int)(#622)ListsorCollections2transfromoverIterables.transform(#623)0.58.0
[improvement] make CheckClassUniquenessTask cacheable (#637)
[fix] Add Javac Settings to uncheck "Use compiler from module target JDK when possible" (#629)
[fix] class uniqueness rule must have a config (#638)
0.59.0
[improvement] Spotless to remove blank lines at start of methods (#641)
0.60.0
0.61.0
0.62.0
0.62.1
[fix] Revert "[improvement] Ensure Optional#orElse argument is not method invocation" (#659)
0.63.0
[improvement] Support auto-applying error-prone suggested fixes (#660)
0.64.0
0.64.1
0.65.0
[improvement] Error-prone check to help prevent logging AuthHeader and BearerToken (#654)
[fix] fix potential NPE when configuring testing (#669)
[fix] Fix refaster compilation to support version recommendations (#667)
0.66.0
[improvement] Ignore DesignForExtension for ParameterizedTest (#673)
0.66.1
1.0.0
1.1.0
1.1.1
-PerrorProneApply.1.2.0
1.3.0
It's possible to restore caching by adding
com.palantir.baseline.restore-test-cache = trueto yourgradle.properties.1.4.0
1.5.0
1.6.0
1.6.1
1.7.0
./gradlew format -Pcom.palantir.baseline-format.eclipse.1.8.0
() -> {}1.8.1
1.8.2
EnableRuleMigrationSupportinJUnit5RuleUsageerrorprone-rule1.9.0
checkImplicitDependenciestask will no longer suggest a fix of the current project.1.10.0
executeoversubmitwhen the result is ignored1.10.1
1.11.0
InputStreamSlowMultibyteReaderror prone check at ERROR severity1.12.0
baseline-ideaplugin now generates configuration more closely aligned with Gradle defaults.UnusedMethodandUnusedVariable.stream.sorted().findFirst()intostream.min(Comparator.naturalOrder())DangerousStringInternUsage: Disallow String.intern() invocations1.12.1
UnusedMethodandUnusedVariablewhich automaticall remove code with side effects.1.13.0
LogSafePreconditionsConstantMessageSlf4jLogsafeArgsin test codeDuration#getNanosmistakes and bans URL in equals methods1.14.0
OptionalOrElseThrowThrowsto prevent throwing from orElseThrow1.15.0
1.16.0
1.17.0
TypeParameterUnusedInFormalserrorprone check is disabled when compiling on Java 13, to workaround an error-prone bug.1.17.1
1.17.2
1.18.0
dependencies are ignored due to false positives as these dependencies
will not appear as dependencies in the generated byte-code, but are in
fact necessary dependencies to compile a given module.
1.19.0
PreconditionsConstantMessageon gradle plugins2.0.0
2.1.0
2.1.1
2.2.0
project) as can interfere with publishing.2.2.1
2.2.2
runtimeClasspathconfiguration by default.2.3.0
{}in safelog exception messages2.4.0
StrictUnusedVariablecheck will catch any unused arguments (e.g. AuthHeaders) to public methods. If you need to suppress this, rename your variable to have an underscore prefix (e.g.s/foo/_foo/) or just run./gradlew classes -PerrorProneApplyto auto-fix2.4.1
module-info.classwhen checking class uniqueness2.4.2
src/*/resourcesdirectory anymore.2.4.3
2.5.0
2.6.0
PreferAssertjto assist migration to AssertJ from legacy test frameworks. It may be necessary to add a dependency onorg.assertj:assertj-corein modules which do not already depend on AssertJ. If there's a technical reason that AssertJ cannot be used,PreferAssertjmay be explicitly disabled to prevent future upgrades from attempting to re-run the migration.2.7.0
StrictUnusedVariablenow ignores variables prefixed with_and the suggested fix will rename all unused parameters in public methods instead of removing them@RunWith(Suite.class)that references JUnit5 classes, as this can cause tests to silently not run!2.8.0
2.8.1
2.9.0
_prefixbaselineErrorProne { patchChecks += 'PreferAssertj' }2.9.1
StrictUnusedVariablecorrectly converts previously suppressed variablesunusedto_2.9.2
StrictUnusedVariablewill preserve side effectsTo enable or disable this check, please contact the maintainers of Excavator.