Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excavator: Upgrades Baseline to the latest version #92

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

svc-excavator-bot
Copy link
Collaborator

@svc-excavator-bot svc-excavator-bot commented Oct 6, 2019

excavator is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

Release Notes

2.14.0

Type Description Link
Improvement Refaster rules for AssertJ tests palantir/gradle-baseline#898
Improvement refaster replacement for assertj hasSize(foo.size) -> hasSameSizeAs palantir/gradle-baseline#900
Fix Keep spotless plugin from eagerly configuring all tasks diffplug/spotless#444
Fix Continue when RefasterRuleBuilderScanner throws palantir/gradle-baseline#904
Improvement Refaster now works on repos using Gradle 6.0 palantir/gradle-baseline#804, palantir/gradle-baseline#906

2.15.0

No documented user facing changes

2.16.0

Type Description Link
Improvement Rewrite ImmutableCollection#addAll to add for arrays palantir/gradle-baseline#743
Improvement Add refaster rule to simplify empty optional asserts palantir/gradle-baseline#911
Improvement Baseline now allows static imports of AssertJ and Mockito methods. palantir/gradle-baseline#915
Improvement Remove refaster AssertjIsOne rule. palantir/gradle-baseline#917
Improvement Add assertj refaster rules for map size asserts palantir/gradle-baseline#919
Improvement Added a Refaster rule to change isEqualTo checks into hasValue checks

2.17.0

Type Description Link
Improvement Implement AssertjCollectionHasSameSizeAsArray palantir/gradle-baseline#922
Improvement Implement assertj map refactors for containsKey and containsEntry palantir/gradle-baseline#925
Improvement Refaster assertj migrations support descriptions with format args palantir/gradle-baseline#926
Improvement Refaster out String.format from describedAs palantir/gradle-baseline#927

2.18.0

Type Description Link
Improvement Refaster rules to simplify negated boolean expressions and extract null checks. palantir/gradle-baseline#935
Improvement Refaster rules for checks that maps do not contain a specific key palantir/gradle-baseline#935
Improvement Refaster rule 'CollectionStreamForEach' palantir/gradle-baseline#942
Improvement ExecutorSubmitRunnableFutureIgnored as error prone ERROR palantir/gradle-baseline#943

2.19.0

Type Description Link
Improvement checkJUnitDependencies detects a possible misconfiguration with spock and JUnit5 which could lead to tests silently not running. palantir/gradle-baseline#951

2.20.0

Type Description Link
Improvement Use Mockito verifyNoInteractions over deprecated verifyZeroInteractions palantir/gradle-baseline#924
Improvement Errorprone rules for usage of Guava static factory methods palantir/gradle-baseline#941
Improvement Fix error-prone UnnecessaryParentheses by default palantir/gradle-baseline#952
Improvement Implement Error Prone ThrowError to discourage throwing Errors in production code
Errors are often handled poorly by libraries resulting in unexpected
behavior and resource leaks. It's not obvious that 'catch (Exception e)'
does not catch Error.
This check is intended to be advisory - it's fine to
@SuppressWarnings("ThrowError") in certain cases, but is usually not
recommended unless you are writing a testing library that throws
AssertionError.
palantir/gradle-baseline#957
Improvement Improve TestCheckUtils.isTestCode test detection palantir/gradle-baseline#958
Improvement Implement Error Prone Slf4jLevelCheck to validate that slf4j level checks agree with contained logging. palantir/gradle-baseline#960

2.20.1

Type Description Link
Fix Suppress error-prone PreferCollectionConstructors on jdk13 palantir/gradle-baseline#968

2.21.0

Type Description Link
Feature Users can opt-in to format their files using our fork of google-java-format (palantir-java-format) palantir/gradle-baseline#936

2.22.0

Automated release, no documented user facing changes

2.23.0

Type Description Link
Improvement Implement error prone ReverseDnsLookup for unexpected reverse dns lookups

Calling address.getHostName may result in a DNS lookup which is a network request,
making the invocation significantly more expensive than expected depending on the
environment.
This check is intended to be advisory - it's fine to
@SuppressWarnings("ReverseDnsLookup") in certain cases, but is usually not
recommended.
palantir/gradle-baseline#970

2.24.0

Type Description Link
Fix The deprecated verifyZeroInteractions now gets rewritten to verifyNoMoreInteractions, which has the same behaviour. palantir/gradle-baseline#975
Improvement ReadReturnValueIgnored: Check that read operation results are not ignored palantir/gradle-baseline#978
Improvement Stop migrating source sets to safe-logging, unless they already have the requisite library (com.palantir.safe-logging:preconditions). palantir/gradle-baseline#981
Improvement For users who opted into palantir-java-format, we now reflow strings and reorder imports. palantir/gradle-baseline#982

2.25.0

Type Description Link
Fix checkstyle Indentation rule is disabled when palantir-java-format is enabled palantir/gradle-baseline#987
Improvement Load palantir-java-format dynamically from the same configuration set up by com.palantir-java-format which is also used to determine the version used by IntelliJ. palantir/gradle-baseline#989

2.26.0

Type Description Link
Improvement Run ./gradlew formatDiff to reformat the relevant sections of any uncommitted changed Java files (relies on git diff -U0 HEAD under the hood) palantir/gradle-baseline#988

2.27.0

Type Description Link
Improvement Slf4jLogsafeArgs fixes safe-log wrapped throwables palantir/gradle-baseline#1001
Improvement DangerousParallelStreamUsage checks for Collection.parallelStream() and StreamSupport utility methods with parallel=true. palantir/gradle-baseline#1005
Improvement DangerousThrowableMessageSafeArg disallows Throwables in SafeArg values.
Throwables must be logged without an Arg wrapper as the last parameter, otherwise unsafe data may be leaked from the unsafe message or the unsafe message of a cause.
palantir/gradle-baseline#997
Improvement Implement a suggested fix for CatchBlockLogException palantir/gradle-baseline#998

2.28.0

Type Description Link
Improvement Implement FinalClass error prone check, replacing the checkstyle implementation palantir/gradle-baseline#1008
Improvement Error prone validation to avoid redundant modifiers palantir/gradle-baseline#1010

2.28.1

Type Description Link
Fix Fix RedundantModifier interpretation of implicit modifiers palantir/gradle-baseline#1014

2.28.2

Type Description Link
Fix Fix RedundantModifier failures types nested in interfaces palantir/gradle-baseline#1017

2.28.3

Type Description Link
Fix Fix error-prone mathcing literal null as a subtype.
The most common issue this fixes is failures on SafeArg.of("name", null)
assuming that the null literal value parameter may be a throwable.
palantir/gradle-baseline#1020

2.29.0

Type Description Link
Improvement Error prone RedundantModifier check supports interface static methods and fields. palantir/gradle-baseline#1021
Fix Ignore module-info.java files to support projects with Jigsaw. palantir/gradle-baseline#1023
Improvement Error Prone StrictCollectionIncompatibleType to guard collection usage palantir/gradle-baseline#1027
Improvement Drop RedundantModifier to SUGGESTION and FinalClass to WARNING

These checks don't imply bugs, and automation will fix failing cases automatically, so it's not necessary to block compilation.
FinalClass moved to warning rather than suggestion because there are a few edge cases (e.g. dependent projects using mockito without inline mock maker) where releases can run into issues if the bots don't fix findings in time.
palantir/gradle-baseline#1028

2.30.0

Type Description Link
Improvement InvocationHandlers which delegate to another object must catch and unwrap
InvocationTargetException, otherwise an UndeclaredThrowableException will be thrown
each time the delegate throws an exception.
palantir/gradle-baseline#1032

To enable or disable this check, please contact the maintainers of Excavator.

@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 2 times, most recently from 49ed03e to 2db76f3 Compare October 10, 2019 17:04
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 5 times, most recently from 0dcd2f9 to 1c38a6f Compare October 17, 2019 22:21
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 2 times, most recently from ff817a6 to e94beb9 Compare October 23, 2019 16:15
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 5 times, most recently from 91702ea to 9d5d380 Compare November 4, 2019 23:59
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch from 9d5d380 to a6791b6 Compare November 7, 2019 19:52
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch from a6791b6 to 5b3e9cb Compare November 11, 2019 18:21
@SerialVelocity SerialVelocity merged commit c825acd into develop Nov 12, 2019
@SerialVelocity SerialVelocity deleted the roomba/latest-baseline-oss branch November 12, 2019 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants