Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to check that heap size is not computed when cgroups memory limits are over 1TB #363

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

mpritham
Copy link
Contributor

After this PR

This PR adds tests for #362.
==COMMIT_MSG==
Add test to check that heap size is not computed when cgroups memory limits are over 1TB
==COMMIT_MSG==

Possible downsides?

N/A.

@mpritham mpritham self-assigned this Nov 16, 2023
@changelog-app
Copy link

changelog-app bot commented Nov 16, 2023

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Add test to check that heap size is not computed when cgroups memory limits are over 1TB

Check the box to generate changelog(s)

  • Generate changelog entry

@mpritham mpritham marked this pull request as ready for review November 16, 2023 22:44
@bulldozer-bot bulldozer-bot bot merged commit a61087c into develop Nov 16, 2023
@bulldozer-bot bulldozer-bot bot deleted the pmarupaka/add-tests-for-1tb-limit branch November 16, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants