Skip to content

Commit

Permalink
Remove dead link from docs (#1400)
Browse files Browse the repository at this point in the history
  • Loading branch information
ferozco authored Jun 9, 2020
1 parent 1c4eb2e commit 731f9e0
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions docs/best-practices/code-reviews/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
[XKCD 'Code Quality', copied under CC BY-NC 2.5](https://xkcd.com/1513/)

The Internet provides a wealth of material on code reviews:
[on the effect of code review on company culture](https://blog.fullstory.com/what-we-learned-from-google-code-reviews-arent-just-for-catching-bugs/),
[on formal security reviews](https://www.owasp.org/images/2/2e/OWASP_Code_Review_Guide-V1_1.pdf),
[shorter guides](https://github.com/thoughtbot/guides/tree/master/code-review),
[longer checklists](https://www.codeproject.com/Articles/524235/Codeplusreviewplusguidelines),
Expand Down Expand Up @@ -34,8 +33,7 @@ This guide covers the following topics:
## Motivation

We perform code reviews (CRs) in order to improve code quality and benefit from
[positive effects on team and company
culture](https://blog.fullstory.com/what-we-learned-from-google-code-reviews-arent-just-for-catching-bugs/).
positive effects on team and company culture.
For example:

- **Committers are motivated** by the notion of a set
Expand All @@ -50,7 +48,7 @@ For example:
team members who can subsequently build on the work done.

- The committer may use a technique or algorithm that reviewers can
learn from. More generally, code reviews help [raise the quality bar across the organization](https://blog.fullstory.com/what-we-learned-from-google-code-reviews-arent-just-for-catching-bugs/).
learn from. More generally, code reviews help raise the quality bar across the organization.

- Reviewers may possess knowledge about programming techniques or the code base that can help
improve or consolidate the change; for example, someone else may be
Expand Down

0 comments on commit 731f9e0

Please sign in to comment.