Bring IntelliJ in sync with ErrorProne on bad inner static class names (

#2447)
palantir · Nov 5, 2022 · a2441bc · a2441bc
1 parent 0c0d009
commit a2441bc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/changelog/@unreleased/pr-2447.v2.yml b/changelog/@unreleased/pr-2447.v2.yml
@@ -0,0 +1,5 @@
+type: fix
+fix:
+  description: Bring IntelliJ in sync with ErrorProne on bad inner static class names
+  links:
+  - https://github.com/palantir/gradle-baseline/pull/2447
diff --git a/gradle-baseline-java-config/resources/idea/intellij-java-palantir-style.xml b/gradle-baseline-java-config/resources/idea/intellij-java-palantir-style.xml
@@ -44,8 +44,10 @@
               <package name="" withSubpackages="true" static="false" />
             </value>
           </option>
+          <!-- Should be a superset of https://github.com/google/error-prone/blob/c481b3f9c2da112db36ccfcbf64e755261a127ab/core/src/main/java/com/google/errorprone/bugpatterns/BadImport.java#L63 -->
           <DO_NOT_IMPORT_INNER>
             <CLASS name="Builder" />
+            <CLASS name="BuilderFactory" />
             <CLASS name="Callback" />
             <CLASS name="Class" />
             <CLASS name="Entry" />
@@ -54,6 +56,7 @@
             <CLASS name="Type" />
             <CLASS name="Key" />
             <CLASS name="Id" />
+            <CLASS name="Identifier" />
             <CLASS name="Provider" />
           </DO_NOT_IMPORT_INNER>
         </GroovyCodeStyleSettings>