Remove baseline-findbugs

palantir · Feb 24, 2017 · b8b534d · b8b534d
1 parent 5e9c1a0
commit b8b534d
Show file tree

Hide file tree

Showing 8 changed files with 3 additions and 175 deletions.
diff --git a/gradle-baseline-java-config/resources/findbugs/excludeFilter.xml b/gradle-baseline-java-config/resources/findbugs/excludeFilter.xml
diff --git a/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/Baseline.groovy b/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/Baseline.groovy
@@ -27,7 +27,6 @@ class Baseline implements Plugin<Project> {
     void apply(Project project) {
         project.plugins.apply BaselineCheckstyle
         project.plugins.apply BaselineConfig
-        project.plugins.apply BaselineFindBugs
         project.plugins.apply BaselineEclipse
         project.plugins.apply BaselineIdea
     }

diff --git a/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineEclipse.groovy b/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineEclipse.groovy
@@ -101,7 +101,7 @@ class BaselineEclipse extends AbstractBaselinePlugin {
             }
         })
 
-        // Configure Findbugs/Checkstyle/JdtUI settings by copying in the default Baseline config file.
+        // Configure Checkstyle/JdtUI settings by copying in the default Baseline config file.
         // Warning: this may interfere with other Gradle plugins that may try to mutate these files.
         project.afterEvaluate { Project p ->
             def eclipseTemplate = project.task(

diff --git a/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineFindBugs.groovy b/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineFindBugs.groovy
diff --git a/...java/src/main/resources/META-INF/gradle-plugins/com.palantir.baseline-findbugs.properties b/...java/src/main/resources/META-INF/gradle-plugins/com.palantir.baseline-findbugs.properties
diff --git a/...-baseline-java/src/test/groovy/com/palantir/baseline/BaselineConfigIntegrationTest.groovy b/...-baseline-java/src/test/groovy/com/palantir/baseline/BaselineConfigIntegrationTest.groovy
@@ -36,6 +36,6 @@ class BaselineConfigIntegrationTest extends IntegrationSpec {
 
         then:
         runTasksSuccessfully('baselineUpdateConfig')
-        assert directory('.baseline').list().toList() == ['checkstyle', 'copyright', 'eclipse', 'findbugs', 'idea']
+        assert directory('.baseline').list().toList() == ['checkstyle', 'copyright', 'eclipse', 'idea']
     }
 }
diff --git a/gradle-baseline-java/src/test/groovy/com/palantir/baseline/BaselineFindBugsTest.groovy b/gradle-baseline-java/src/test/groovy/com/palantir/baseline/BaselineFindBugsTest.groovy
diff --git a/gradle-baseline-java/src/test/groovy/com/palantir/baseline/BaselineTest.groovy b/gradle-baseline-java/src/test/groovy/com/palantir/baseline/BaselineTest.groovy
@@ -18,7 +18,7 @@ package com.palantir.baseline
 
 import com.palantir.baseline.plugins.BaselineCheckstyle
 import com.palantir.baseline.plugins.BaselineEclipse
-import com.palantir.baseline.plugins.BaselineFindBugs
+
 import com.palantir.baseline.plugins.Baseline
 
 import static org.junit.Assert.assertTrue
@@ -49,11 +49,6 @@ class BaselineTest {
         assertTrue project.plugins.hasPlugin(Baseline.class)
     }
 
-    @Test
-    public void baselineFindBugsProjectApplied() {
-        assertTrue project.plugins.hasPlugin(BaselineFindBugs.class)
-    }
-
     @Test
     public void baselineCheckstyleProjectApplied() {
         assertTrue project.plugins.hasPlugin(BaselineCheckstyle.class)