Don't cache when applying errorprone / refaster rules (#696)

No longer cache javaCompile tasks when applying errorprone or refaster checks.
palantir · Jul 17, 2019 · cca1b5e · cca1b5e
1 parent ce456dd
commit cca1b5e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/changelog/@unreleased/pr-696.v2.yml b/changelog/@unreleased/pr-696.v2.yml
@@ -0,0 +1,6 @@
+type: fix
+fix:
+  description: No longer cache javaCompile tasks when applying errorprone or refaster
+    checks.
+  links:
+  - https://github.com/palantir/gradle-baseline/pull/696
diff --git a/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineErrorProne.java b/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineErrorProne.java
@@ -114,6 +114,8 @@ public void apply(Project project) {
                                 errorProneOptions.getErrorproneArgumentProviders().add(() -> ImmutableList.of(
                                         "-XepPatchChecks:refaster:" + refasterRulesFile.get().getAbsolutePath(),
                                         "-XepPatchLocation:IN_PLACE"));
+                                // Don't attempt to cache since it won't capture the source files that might be modified
+                                javaCompile.getOutputs().cacheIf(t -> false);
                             } else if (project.hasProperty(PROP_ERROR_PRONE_APPLY)) {
                                 javaCompile.getOptions().setWarnings(false);
                                 // TODO(gatesn): Is there a way to discover error-prone checks?
@@ -123,6 +125,8 @@ public void apply(Project project) {
                                         "-XepPatchChecks:" + Joiner.on(',')
                                                 .join(errorProneExtension.getPatchChecks().get()),
                                         "-XepPatchLocation:IN_PLACE"));
+                                // Don't attempt to cache since it won't capture the source files that might be modified
+                                javaCompile.getOutputs().cacheIf(t -> false);
                             }
                         });
             });