InvocationHandlerDelegation false positive?

[iamdanfox]

What happened?

With baseline 3.23.0, the following code trips over

protected Object handleInvocation(Object _proxy, Method method, Object[] args) throws Throwable {
            try {
                Object ret = method.invoke(delegate, args);
                log(AuditResult.SUCCESS);
                return ret;
            } catch (InvocationTargetException | UndeclaredThrowableException e) {
                log(AuditUtil.getResultForThrowable(e.getCause()));
                throw e.getCause();
            } catch (Throwable e) {
                log(AuditUtil.getResultForThrowable(e));
                throw e;
            } finally {
                context.clear();
            }
        }

Error produced:

> Task :audit-api:compileJava
/Volumes/git/foundry-audit/audit-api/src/main/java/com/palantir/foundry/audit/AuditLoggingProxy.java:41: warning: [InvocationHandlerDelegation] InvocationHandlers which delegate to another object must catch and unwrap InvocationTargetException, otherwise an UndeclaredThrowableException will be thrown each time the delegate throws an exception.
                Object ret = method.invoke(delegate, args);
                                          ^
  This check is intended to be advisory. It's fine to @SuppressWarnings("InvocationHandlerDelegation") in certain cases, but is usually not recommended.
    (see https://github.com/palantir/gradle-baseline#baseline-error-prone-checks)

What did you want to happen?

I think this code is fine and it's just a straight-up false positive?? (possibly multi-branch catch block?)

[carterkozak]

Why are we unwrapping UndeclaredThrowableException?

[iamdanfox]

I guess people do sometimes use this auditing library to audit a big old chain of proxies wrapping proxies (e.g. our SLOs stuff)?

[carterkozak]

Even so, we wouldn't want to throw UndeclaredThrowableException.getCause even if only the cause is audited.