Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.57.1 breaks error-prone generated excluded paths #1570

Closed
schlosna opened this issue Nov 26, 2020 · 0 comments · Fixed by #1571
Closed

3.57.1 breaks error-prone generated excluded paths #1570

schlosna opened this issue Nov 26, 2020 · 0 comments · Fixed by #1571

Comments

@schlosna
Copy link
Contributor

What happened?

As seen in excavator bump PR palantir/tritium#925 , the changes in #1568 do not seem to handle cases that previously were excluded such as build/metricSchema/generated_src used by metric-schema which is causing the baseline bump excavator on tritium to fail compilation: https://app.circleci.com/pipelines/github/palantir/tritium/906/workflows/7c65b97b-b475-46fc-a1e1-b5a4bf7198a0/jobs/11565

What did you want to happen?

Baseline bump to successfully compile so that the 🤖 work while we eat 🦃
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude generated sources from error-prone palantir/gradle-baseline
1 participant
@schlosna