Exclude generated sources from error-prone #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
iamdanfox
approved these changes
Nov 27, 2020
schlosna
commented
Nov 29, 2020
| static String excludedPathsRegex() { | ||
| // don't want backslashes on windows to break our regex | ||
| String separator = File.separator.contains("\\") ? Pattern.quote("\\") : File.separator; | ||
| return String.format(".*%s(build|generated_.*[sS]rc|src%sgenerated.*)%s.*", separator, separator, separator); |
There was a problem hiding this comment.
@iamdanfox we might be able to remove build from regex here, or might want to constrain the pattern to avoid falsely matching say com/foo/build/Bar.java.
There was a problem hiding this comment.
Yeah this feels a bit dangerous. I'd suggest we do something like build.*generated since almost all code-gen plugins I've seen put source files on a path with a generated component.
|
|
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
As seen in excavator bump PR palantir/tritium#925 , the changes in #1568 do not seem to handle cases that previously were excluded such as
build/metricSchema/generated_srcused bymetric-schemawhich is causing the baseline bump excavator on tritium to fail compilation: https://app.circleci.com/pipelines/github/palantir/tritium/906/workflows/7c65b97b-b475-46fc-a1e1-b5a4bf7198a0/jobs/11565After this PR
==COMMIT_MSG==
Exclude generated sources from error-prone
==COMMIT_MSG==
Closes #1570
Possible downsides?
Probably want some additional test cases.