Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically turn off Slf4jLogsafeArgs in test code #407

Closed
iamdanfox opened this issue Oct 10, 2018 · 2 comments
Closed

Automatically turn off Slf4jLogsafeArgs in test code #407

iamdanfox opened this issue Oct 10, 2018 · 2 comments

Comments

@iamdanfox
Copy link
Contributor

What happened

I just got an error message from Slf4jLogsafeArgs in conjure-java-runtime tests:

> Task :okhttp-clients:compileTestJava
/Users/dfox/conjure-java-runtime/okhttp-clients/src/test/java/com/palantir/conjure/java/okhttp/FlowControlTest.java:89: warning: [Slf4jLogsafeArgs] slf4j log statement does not use logsafe parameters for arguments [1, 2]
            log.info("Average rate is {}, 1 minute rate is {}", rate.getMeanRate(), rate.getOneMinuteRate());
                    ^
    (see https://github.com/palantir/gradle-baseline#baseline-error-prone-checks)

What should have happened

This should never have wasted my time because it's test-only code so I don't care if it's a logsafe arg.

@stale
Copy link

stale bot commented Jan 7, 2019

This issue has been automatically marked as stale because it has not been touched in the last 60 days. Please comment if you'd like to keep it open, otherwise it'll be closed in 7 days time.

@stale stale bot added the stale label Jan 7, 2019
@iamdanfox
Copy link
Contributor Author

Let's keep this open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant