Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency on mockito-errorprone #1085

Merged
merged 2 commits into from
Dec 4, 2019
Merged

Add dependency on mockito-errorprone #1085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ab58ba
Add dependency on mockito-errorprone
pkoenig10 Dec 4, 2019
f902adc
Add generated changelog entries
pkoenig10 Dec 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions baseline-error-prone/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ apply from: "${rootDir}/gradle/publish-jar.gradle"

dependencies {
compile 'com.google.errorprone:error_prone_core'
compile 'org.mockito:mockito-errorprone'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be cleaner to provide it as a runtime dependency since nothing compiles against it. baseline-error-prone isn't used as a library dependency, so it doesn't matter much either way

Suggested change
compile 'org.mockito:mockito-errorprone'
runtimeOnly 'org.mockito:mockito-errorprone'


testCompile gradleApi()
testCompile 'com.palantir.tokens:auth-tokens'
Expand Down
6 changes: 6 additions & 0 deletions changelog/@unreleased/pr-1085.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
type: improvement
improvement:
description: Baseline now depends on `mockito-errorprone` to get Mockito error-prone
checks.
links:
- https://github.com/palantir/gradle-baseline/pull/1085
2 changes: 1 addition & 1 deletion versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ commons-lang:commons-lang = 2.6
org.assertj:assertj-core = 3.14.0
org.hamcrest:hamcrest-core = 2.2
org.junit.jupiter:* = 5.5.2
org.mockito:mockito-core = 3.1.0
org.mockito:* = 3.1.0
com.fasterxml.jackson.*:* = 2.10.1
com.palantir.tokens:auth-tokens = 3.6.1

Expand Down