Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move assertj code -> palantir/assertj-automation #1125

Merged
merged 4 commits into from
Dec 17, 2019

Conversation

iamdanfox
Copy link
Contributor

Before this PR

Internally, many excavators to update people's baseline would not auto-merge because they make some trivial assertj changes (which require a human +1).

After this PR

==COMMIT_MSG==
All assertj-related code-rewriting now lives in the https://github.com/palantir/assertj-automation repo.
==COMMIT_MSG==

Possible downsides?

  • if people want to 'lock-in' the PreferAssertj check, they'll need to take an explicit dependency on com.palantir.assertj-automation:assertj-error-prone

@changelog-app
Copy link

changelog-app bot commented Dec 17, 2019

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

All assertj-related code-rewriting now lives in the https://github.com/palantir/assertj-automation repo.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from dansanduleac December 17, 2019 15:11
@iamdanfox iamdanfox changed the title Delete assertj stuff Move assertj code -> palantir/assertj-automation Dec 17, 2019
@iamdanfox iamdanfox requested review from carterkozak and removed request for dansanduleac December 17, 2019 15:24
@carterkozak
Copy link
Contributor

👍

@iamdanfox
Copy link
Contributor Author

🚂

@bulldozer-bot bulldozer-bot bot merged commit f18dcd8 into develop Dec 17, 2019
@bulldozer-bot bulldozer-bot bot deleted the dfox/delete-assertj-stuff branch December 17, 2019 15:41
@svc-autorelease
Copy link
Collaborator

Released 2.44.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants