Fix: baseline-idea correctly filters save actions to java files #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdanfox
reviewed
Jan 10, 2020
| @@ -350,7 +350,7 @@ class BaselineIdea extends AbstractBaselinePlugin { | |||
| appendNode('option', [value: 'reformat']) | |||
| } | |||
| appendNode('option', [name: 'configurationPath', value: '']) | |||
| appendNode('inclusions').appendNode('set').with { | |||
| appendNode('option', [name: 'inclusions']).appendNode('set').with { | |||
| appendNode('option', [value: 'src/.*\\.java']) | |||
There was a problem hiding this comment.
will the src/ fail on windows? Should we just use File.separator instead?
iamdanfox
approved these changes
Jan 10, 2020
iamdanfox
reviewed
Jan 10, 2020
| appendNode('inclusions').appendNode('set').with { | ||
| appendNode('option', [value: 'src/.*\\.java']) | ||
| appendNode('option', [name: 'inclusions']).appendNode('set').with { | ||
| appendNode('option', [value: "src${File.pathSeparator}.*\\.java"]) |
There was a problem hiding this comment.
I think you got the wrong one mate -
@Test
public void foo() {
System.out.println(File.pathSeparator); // prints ':'
System.out.println(File.separator); // prints '/'
}
|
👍 |
|
Released 2.48.2 |
This was referenced Jan 10, 2020
This was referenced Jan 10, 2020
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Made a mistake in configuring the include filters for the Save Actions plugin.
Thus, the plugin would format any file on save, not just java files.
After this PR
==COMMIT_MSG==
Fix a bug in the Save Actions plugin configuration where it would format any file on save, instead of just java files.
==COMMIT_MSG==
Possible downsides?