Fix LoggerEnclosingClass edge cases for type parameters and anonymous classes
#1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
commented
Jan 16, 2020
| private static Symbol.ClassSymbol enclosingConcreteClass(Symbol.ClassSymbol input) { | ||
| Symbol.ClassSymbol current = input; | ||
| while (current != null && current.isAnonymous()) { | ||
| current = ASTHelpers.enclosingClass(current); |
There was a problem hiding this comment.
I haven't encountered this in the wild (it's an odd thing to do) but fixed it while I'm here.
carterkozak
commented
Jan 16, 2020
| @@ -83,8 +83,16 @@ public Description matchVariable(VariableTree tree, VisitorState state) { | |||
| return buildDescription(classArgument) | |||
| .addFix(fix.replace( | |||
| classArgument, | |||
| SuggestedFixes.prettyType(state, fix, enclosingClassSymbol.type) + ".class") | |||
| enclosingClassSymbol.name + ".class") | |||
There was a problem hiding this comment.
Simple name is sufficient here because the code we're updating is nested within the type -- the previous approach using prettyType wasn't necessary and included type parameters.
iamdanfox
approved these changes
Jan 16, 2020
|
dozer? |
|
Released 2.49.1 |
This was referenced Jan 16, 2020
This was referenced Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Possible to suggest
LoggerFactory.getLogger(Bar<T>.class)instead ofLoggerFactory.getLogger(Bar.class).Also possible to fail when loggers are defined as fields of anonymous classes.
After this PR
==COMMIT_MSG==
Fix
LoggerEnclosingClassedge cases for type parameters and anonymous classes==COMMIT_MSG==