Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Pcom.palantir.baseline-error-prone.disable #1213

Merged
merged 4 commits into from
Feb 5, 2020

Conversation

iamdanfox
Copy link
Contributor

@iamdanfox iamdanfox commented Feb 5, 2020

Before this PR

I want to start running some unit tests with Java13, but currently error-prone barfs, see:

After this PR

==COMMIT_MSG==
./gradlew compileJava -Pcom.palantir.baseline-error-prone.disable turns off error-prone, to allow compilation on Java 13 which is not yet supported by error-prone.
==COMMIT_MSG==

Possible downsides?

  • not sure I want people to start using this as part of their regular dev workflow :/

@changelog-app
Copy link

changelog-app bot commented Feb 5, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

./gradlew compileJava -Pcom.palantir.baseline-error-prone.disable turns off error-prone, to allow compilation on Java 13 which is not yet supported by error-prone.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from CRogers February 5, 2020 15:01
errorProneOptions.check("UnnecessaryLambda", CheckSeverity.OFF);
}
});
});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this block was pretty much an exact duplicate of a block above, so I moved this logic further down.

@bulldozer-bot bulldozer-bot bot merged commit 7610bac into develop Feb 5, 2020
@bulldozer-bot bulldozer-bot bot deleted the dfox/support-a-disable-flag branch February 5, 2020 15:14
@svc-autorelease
Copy link
Collaborator

Released 3.3.0

This was referenced Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants