-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
License derived from .baseline/copyright #1217
Conversation
Generate changelog in
|
gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineFormat.java
Outdated
Show resolved
Hide resolved
...ine-java/src/test/groovy/com/palantir/baseline/BaselineFormatCopyrightIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
Looks cool, might be worth a mention in the README that the copyright directory is important, and that running |
# Conflicts: # gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineFormat.java
|
||
To automatically update all files with mismatching/missing copyrights, run `./gradlew format`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
./gradlew format
feels a bit odd here. I think I'd almost recommend spotlessApply
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it the same thing though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommending another command that format
intentionally aliases feels like it might confuse people.
So running this internally on sls-logging, it seems it currently wrecks the world (and replaces our internal shorthand license with the apache one, which isn't correct). Think we need to:
|
Before this PR
Enforcing copyright file using checkstyle which is hard to change and not in sync with whatever files are in
.baseline/copyright
.After this PR
==COMMIT_MSG==
Enforcing copyright based on the first file (lexicographically) founds in
.baseline/copyright
.This now uses spotless, which means that we can now autofix all copyrights using gradle.
It also allows us to enforce this copyright on groovy files, which we didn't have before.
==COMMIT_MSG==
Possible downsides?