-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checkClassUniqueness works with conjure #1250
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
iamdanfox
force-pushed
the
dfox/fix-class-uniqueness
branch
from
February 20, 2020 17:42
7109a41
to
a17dca2
Compare
CRogers
approved these changes
Feb 20, 2020
Released 3.4.3 |
This was referenced Feb 20, 2020
This was referenced Feb 20, 2020
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
@dsinghvi reported in #dev-foundry-infra some problems with checkClassUniqueness giving inconsistent results on CI and locally. (We've also had other complaints related to gradle-atlas).
Running the task locally, it seemed no conjure objects were being generated, so the lockfile would be different than if conjure objects did exist.
After this PR
==COMMIT_MSG==
checkClassUniqueness should now behave consistently when asked to analyze configurations that are
builtBy
other tasks (e.g. gradle-conjure, gradle-atlas)==COMMIT_MSG==
Possible downsides?