Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkClassUniqueness works with conjure #1250

Merged
merged 4 commits into from
Feb 20, 2020

Conversation

iamdanfox
Copy link
Contributor

Before this PR

@dsinghvi reported in #dev-foundry-infra some problems with checkClassUniqueness giving inconsistent results on CI and locally. (We've also had other complaints related to gradle-atlas).

Running the task locally, it seemed no conjure objects were being generated, so the lockfile would be different than if conjure objects did exist.

After this PR

==COMMIT_MSG==
checkClassUniqueness should now behave consistently when asked to analyze configurations that are builtBy other tasks (e.g. gradle-conjure, gradle-atlas)
==COMMIT_MSG==

Possible downsides?

  • we don't really know why the current thing isn't working, as it seems like we're doing the recommended thing.

@changelog-app
Copy link

changelog-app bot commented Feb 20, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

checkClassUniqueness should now behave consistently when asked to analyze configurations that are builtBy other tasks (e.g. gradle-conjure, gradle-atlas)

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from ferozco February 20, 2020 17:41
@bulldozer-bot bulldozer-bot bot merged commit e890e1c into develop Feb 20, 2020
@bulldozer-bot bulldozer-bot bot deleted the dfox/fix-class-uniqueness branch February 20, 2020 18:07
@svc-autorelease
Copy link
Collaborator

Released 3.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants