Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate VisibleForTesting validation from checkstyle to errorprone #1253

Merged
merged 3 commits into from
Feb 27, 2020

Conversation

carterkozak
Copy link
Contributor

==COMMIT_MSG==
Migrate VisibleForTesting validation from checkstyle to errorprone
==COMMIT_MSG==

The fix exists primarily for documentation, it's not applied by default because it could break API and cause compilation to fail.

@changelog-app
Copy link

changelog-app bot commented Feb 21, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Migrate VisibleForTesting validation from checkstyle to errorprone

Check the box to generate changelog(s)

  • Generate changelog entry

Sorry, something went wrong.

@policy-bot policy-bot bot requested a review from iamdanfox February 21, 2020 21:45
@jkozlowski
Copy link
Contributor

@iamdanfox ping

@carterkozak carterkozak requested a review from ferozco February 27, 2020 16:19
@ferozco
Copy link
Contributor

ferozco commented Feb 27, 2020

👍 Thanks @carterkozak!

@jkozlowski jkozlowski merged commit 61fc138 into develop Feb 27, 2020
@svc-autorelease
Copy link
Collaborator

Released 3.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants